aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlan Modra <amodra@gmail.com>2016-10-05 16:52:24 +1030
committerAlan Modra <amodra@gmail.com>2016-10-06 09:39:56 +1030
commit2b804145796e948fa4c025c07eb201e700281e6b (patch)
treec1a7b298379035822fa1d77ebe2a9a82d71fdca4 /binutils
parent[GOLD] -Wimplicit-fallthrough warning fixes (diff)
downloadbinutils-gdb-2b804145796e948fa4c025c07eb201e700281e6b.tar.gz
binutils-gdb-2b804145796e948fa4c025c07eb201e700281e6b.tar.bz2
binutils-gdb-2b804145796e948fa4c025c07eb201e700281e6b.zip
-Wimplicit-fallthrough error fixes
Well, not all are errors, but a little more substantive than just fiddling with comments. bfd/ * coffcode.h (coff_slurp_symbol_table): Revert accidental commit made 2015-01-08. * elf32-nds32.c (nds32_elf_grok_psinfo): Add missing break. * reloc.c (bfd_default_reloc_type_lookup): Add missing breaks. opcodes/ * arc-ext.c (create_map): Add missing break. * msp430-decode.opc (encode_as): Likewise. * msp430-decode.c: Regenerate. binutils/ * coffdump.c (dump_coff_where): Add missing break. * stabs.c (stab_xcoff_builtin_type): Likewise. gas/ * config/tc-arc.c (find_opcode_match): Add missing break. * config/tc-i960.c (get_cdisp): Likewise. * config/tc-metag.c (parse_swap, md_apply_fix): Likewise. * config/tc-mt.c (md_parse_option): Likewise. * config/tc-nds32.c (nds32_apply_fix): Likewise. * config/tc-hppa.c (pa_ip): Assert rather than testing last condition of multiple if statements. * config/tc-s390.c (s390_exp_compare): Return 0 on error. * config/tc-tic4x.c (tic4x_operand_parse): Add as_bad and break out of case rather than falling into next case. Formatting. ld/ * plugin.c (asymbol_from_plugin_symbol): Avoid compiler warning by adding return.
Diffstat (limited to 'binutils')
-rw-r--r--binutils/ChangeLog5
-rw-r--r--binutils/coffdump.c1
-rw-r--r--binutils/stabs.c1
3 files changed, 7 insertions, 0 deletions
diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index c40ceda1181..bef5ec0a2ac 100644
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,8 @@
+2016-10-06 Alan Modra <amodra@gmail.com>
+
+ * coffdump.c (dump_coff_where): Add missing break.
+ * stabs.c (stab_xcoff_builtin_type): Likewise.
+
2016-09-29 Alan Modra <amodra@gmail.com>
* readelf.c (process_arch_specific): Call process_power_specific
diff --git a/binutils/coffdump.c b/binutils/coffdump.c
index e9aa76fcf78..640445830de 100644
--- a/binutils/coffdump.c
+++ b/binutils/coffdump.c
@@ -267,6 +267,7 @@ dump_coff_where (struct coff_where *p)
break;
case coff_where_strtag:
printf ("STRTAG");
+ break;
case coff_where_entag:
printf ("ENTAG");
break;
diff --git a/binutils/stabs.c b/binutils/stabs.c
index aebde7afe97..d209094d031 100644
--- a/binutils/stabs.c
+++ b/binutils/stabs.c
@@ -3432,6 +3432,7 @@ stab_xcoff_builtin_type (void *dhandle, struct stab_handle *info,
case 9:
name = "unsigned";
rettype = debug_make_int_type (dhandle, 4, TRUE);
+ break;
case 10:
name = "unsigned long";
rettype = debug_make_int_type (dhandle, 4, TRUE);