aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Burgess <andrew.burgess@embecosm.com>2019-04-11 23:51:48 +0100
committerAndrew Burgess <andrew.burgess@embecosm.com>2019-04-12 09:28:16 +0100
commit62253a61473764b0d084b01eff06a93fb38bb2e3 (patch)
tree5c31da87c5f59d737da12b2b6eec015c898ce4f2 /gdb/language.h
parentAutomatic date update in version.in (diff)
downloadbinutils-gdb-62253a61473764b0d084b01eff06a93fb38bb2e3.tar.gz
binutils-gdb-62253a61473764b0d084b01eff06a93fb38bb2e3.tar.bz2
binutils-gdb-62253a61473764b0d084b01eff06a93fb38bb2e3.zip
gdb: Remove LANG_MAGIC
The language_defn structure has an la_magic field, this used to be used as a basic check that the language_defn structure had the expected layout - at least the end of the structure was where we expected it to be. This feature only really makes sense if we imagine GDB dynamically loading language support from dynamic libraries, where a version mismatch might cause problems. However, in current GDB language support is statically built into GDB, and since this commit: commit 47e77640be31fc1a4eb3718f594ed5fd0faff065 Date: Thu Jul 20 18:28:01 2017 +0100 Make language_def O(1) the existing (if pointless) check of the la_magic field was removed. There now appears to be no use of the la_magic field, and I propose that we delete it. There should be no user visible changes after this commit. gdb/ChangeLog: * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC. * c-lang.c (c_language_defn): Likewise. (cplus_language_defn): Likewise. (asm_language_defn): Likewise. (minimal_language_defn): Likewise. * d-lang.c (d_language_defn): Likewise. * f-lang.c (f_language_defn): Likewise. * go-lang.c (go_language_defn): Likewise. * language.c (unknown_language_defn): Likewise. (auto_language_defn): Likewise. * language.h (struct language_defn): Remove la_magic field. (LANG_MAGIC): Delete. * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC. * objc-lang.c (objc_language_defn): Likewise. * opencl-lang.c (opencl_language_defn): Likewise. * p-lang.c (pascal_language_defn): Likewise. * rust-lang.c (rust_language_defn): Likewise.
Diffstat (limited to 'gdb/language.h')
-rw-r--r--gdb/language.h8
1 files changed, 0 insertions, 8 deletions
diff --git a/gdb/language.h b/gdb/language.h
index a982e1977d2..3e0bc9d0d46 100644
--- a/gdb/language.h
+++ b/gdb/language.h
@@ -449,16 +449,8 @@ struct language_defn
struct gdbarch *gdbarch,
const struct block *expr_block,
CORE_ADDR expr_pc);
-
- /* Add fields above this point, so the magic number is always last. */
- /* Magic number for compat checking. */
-
- long la_magic;
-
};
-#define LANG_MAGIC 910823L
-
/* Pointer to the language_defn for our current language. This pointer
always points to *some* valid struct; it can be used without checking
it for validity.